Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 4.5-7.16] Remove ?pretty of request (#5532) #5540

Merged
merged 2 commits into from
Jun 9, 2023
Merged

[Backport 4.5-7.16] Remove ?pretty of request (#5532) #5540

merged 2 commits into from
Jun 9, 2023

Conversation

yenienserrano
Copy link
Member

Backport c39128a from #5532.

@yenienserrano
Remove ?pretty of request (#5532)
13558ac 
* Remove ?pretty of request

* Add changelog

---------

Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit c39128a)
@yenienserrano yenienserrano requested a review from a team as a code owner June 8, 2023 09:07
@yenienserrano yenienserrano changed the title [Backport 4.5-7.10] Remove ?pretty of request (#5532) [Backport 4.5-7.16] Remove ?pretty of request (#5532) Jun 8, 2023
@yenienserrano yenienserrano linked an issue Jun 8, 2023 that may be closed by this pull request
Wazuh API usage - Statistics task #5247
Closed
Desvelao
Desvelao previously approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:

code 🟢
test 🟢

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

Other

Test Result
Wait for the job to run and see in the imposter or manager logs that the ?pretty is not there 🟢

Details

🟢 Wait for the job to run and see in the imposter or manager logs that the ?pretty is not there

image

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Code coverage (Jest) % values
Statements 9.33% ( 3522 / 37757 )
Branches 4.92% ( 1434 / 29125 )
Functions 8.02% ( 752 / 9379 )
Lines 9.42% ( 3402 / 36125 )

asteriscos
asteriscos approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@asteriscos asteriscos merged commit f1fd018 into 4.5-7.16 Jun 9, 2023
@asteriscos asteriscos deleted the backport-5532-to-4.5-7.16 branch June 9, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@Desvelao Desvelao Desvelao left review comments

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wazuh API usage - Statistics task
3 participants
@yenienserrano @asteriscos @Desvelao